Add support for debugging macOS app bundles #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
This is pending testing on macOS :) |
WardenGnaw
force-pushed
the
dev/waan/supportMacOSApp
branch
from
121bdad
to
b3790bd
Compare
|
@gregg-miskelly Perchance do you know how to default each test to have this new compiler as unsupported or do I have to add an UnsupportedCompiler tag to the existing tests? |
I have no idea. You could ask the Production Diag folks (Justin Anderson, Del) if they remember anything. |
WardenGnaw
force-pushed
the
dev/waan/supportMacOSApp
branch
from
b3790bd
to
3bd92cc
Compare
This PR adds support for debugging app bundles on macOS. LLDB understands how to handle app bundles when provided to -file-exec-and-symbols. Reference: ./lldb-mi (gdb) -file-exec-and-symbols /Applications/VLC.app ^done (gdb) =library-loaded,id="/Applications/VLC.app/Contents/MacOS/VLC",target-name="/Applications/VLC.app/Contents/MacOS/VLC",host-name="/Applications/VLC.app/Contents/MacOS/VLC",symbols-loaded="0",loaded_addr="-",size="20480"
Add XCodeBuild Compiler Add support for running tests Missing actual test Move to correct location
WardenGnaw
force-pushed
the
dev/waan/supportMacOSApp
branch
from
3bd92cc
to
3a23419
Compare
|
@gregg-miskelly When you have the time, can you re-review this PR. I was able to add a XCode project that compiles a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for debugging app bundles on macOS.
LLDB understands how to handle app bundles when provided to
-file-exec-and-symbols.
Reference:
./lldb-mi
(gdb)
-file-exec-and-symbols /Applications/VLC.app
^done
(gdb)
=library-loaded,id="/Applications/VLC.app/Contents/MacOS/VLC",target-name="/Applications/VLC.app/Contents/MacOS/VLC",host-name="/Applications/VLC.app/Contents/MacOS/VLC",symbols-loaded="0",loaded_addr="-",size="20480"
Added MacOSApp Test to CppTests.