Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SupportsInstructionBreakpoints #1192

Merged
merged 8 commits into from
Aug 16, 2021
Merged

Add support for SupportsInstructionBreakpoints #1192

merged 8 commits into from
Aug 16, 2021

Conversation

WardenGnaw
Copy link
Member

@WardenGnaw WardenGnaw commented Aug 9, 2021 •
edited
Loading

Adds support for instruction breakpoints and will return reason InstructionBreakpoint when stopped.

TODO:

  • Add Tests

@WardenGnaw WardenGnaw self-assigned this Aug 9, 2021
@WardenGnaw WardenGnaw marked this pull request as ready for review August 12, 2021 19:07
gregg-miskelly
gregg-miskelly requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See comments)

@WardenGnaw WardenGnaw merged commit 3f1c642 into main Aug 16, 2021
@WardenGnaw WardenGnaw deleted the dev/waan/instructionBreakpoints branch September 21, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Assignees

@WardenGnaw WardenGnaw

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WardenGnaw @gregg-miskelly