Fix PlatformUtilities methods #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregg-miskelly
approved these changes
Aug 30, 2021
|
Investigating failing macOS tests. May be an indicator of other macOS issues. |
Use 'RuntimeInformation.IsOSPlatform' instead of 'Environment.OSVersion.Platform' Environment.OSVersion.Platform on .NET 5 is returning 'Unix' for macOS which is causing a bunch of our cases to not work. Tested RuntimeInformation.IsOSPlatform(OSPlatform.Windows) on net472 on Windows and it returns true.
darwin-debug does not like environment with spaces, and it is sent by lldb-mi. Needs to be fixed externally.
WardenGnaw
force-pushed
the
dev/waan/fixPlatformUtilities
branch
from
f24375a
to
ab6391e
Compare
|
Disabling Tests since they seem to be a test machine only issue / lldb-mi external issue. Choosing to complete this PR instead since without these changes, it causes the IsOSX checks to return false on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'RuntimeInformation.IsOSPlatform' instead of
'Environment.OSVersion.Platform'
Environment.OSVersion.Platform on .NET 5 is returning 'Unix' for macOS
which is causing a bunch of our cases to not work.
Tested RuntimeInformation.IsOSPlatform(OSPlatform.Windows) on net472 on
Windows and it returns true.