Use pid to determine program if one is not configured for local attach #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the "program" configuration optional for local attach cases. The configured program is always preferred if it is defined.
WardenGnaw
reviewed
Nov 1, 2021
| @@ -1135,6 +1135,10 @@ protected override void HandleAttachRequestAsync(IRequestResponder<AttachArgumen | |||
| SetCommonDebugSettings(responder.Arguments.ConfigurationProperties); | |||
|
|
|||
| string program = responder.Arguments.ConfigurationProperties.GetValueAsString("program"); | |||
| if (isLocal && program == null) | |||
| { | |||
| program = Process.GetProcessById(pid).MainModule.FileName; | |||
There was a problem hiding this comment.
Downstream in MICore they still have a hard check for program that it grabs from the ConfigurationProperties JSON object.
See string launchJson = JsonConvert.SerializeObject(responder.Arguments.ConfigurationProperties); below.
You will need to set it for it not to fail the PathExe check in MICore.
responder.Arguments.ConfigurationProperties["program"] = program;
Co-authored-by: Andrew Wang <waan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the "program" configuration optional for local attach cases. The configured program is always preferred if it is defined.
This was stemmed from a discussion over in microsoft/vscode-cpptools#5713 where another user had suggested a change like this based on feedback from one of the maintainers, but I didn't see an open pull request for it. The goal was to ultimately relax requiring the
programconfiguration key to be set while debugging with local attach by pid on Linux. If this is merged, I think the C++ plugin's settings schema would also need to be altered to relax theprogramrequirement.Word of warning: I wasn't able to figure out the debug procedure for the VSCode C++ extension to verify this change, but I thought it was small enough to at least propose for discussion.
I thought I should note there is a pretty good workaround I saw in microsoft/vscode-cpptools#1272 which suggests using the procfs to infer the executable within VSCode's settings system.