Improve messages for unknown breakpoints and watchpoints. (#1282) #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gareth-rees
force-pushed
the
1282-unknown-breakpoint
branch
from
5ad3fc7
to
2570e98
Compare
|
Continuous integration failure on Linux does not seem to be related to this pull request: |
I'm taking a look at this, something within infrastructure changed or that endpoint it pulls from is dead and we need to use a different machine. |
…1282) The C/C++ extension does not support all the features of GDB breakpoints and watchpoints, so users may need to set breakpoints via "-exec break ..." in the DEBUG CONSOLE, and similarly for watchpoints via "-exec watch ...". When these are hit, include the available information in the exception message.
gareth-rees
force-pushed
the
1282-unknown-breakpoint
branch
from
2570e98
to
e251975
Compare
gregg-miskelly
requested changes
Mar 4, 2022
|
Here is the ResourcesStrings.Designer.cs that VS generates: |
|
Otherwise LGTM |
gareth-rees
force-pushed
the
1282-unknown-breakpoint
branch
from
2910f81
to
b27dbd0
Compare
Thanks, I put that in the pull request. |
gregg-miskelly
approved these changes
Mar 4, 2022
|
@gregg-miskelly Thanks for reviewing and helping me with the internationalization. |
|
No problem. Thanks for taking the time to submit this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C/C++ extension does not support all the features of GDB breakpoints and watchpoints, so users may need to set breakpoints via
-exec break ...in the DEBUG CONSOLE, and similarly for watchpoints via-exec watch .... When these are hit, include the available information in the exception message instead of just "Unknown breakpoint" or "Unknown watchpoint". Fixes #1282.The new behaviour for unknown breakpoints and unknown watchpoints (respectively) is shown in the screenshots below.