Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story 1556891: [MIEngine Natvis] Support multi-dimensional arrays #1346

Merged
merged 13 commits into from
Sep 9, 2022

Conversation

gc46
Copy link
Contributor

@gc46 gc46 commented Aug 31, 2022

Forward

1D case:
image

2D case:
image

3D case:
image

@gc46
Copy link
Contributor Author

gc46 commented Aug 31, 2022

Backward

1D case:
image

2D case:
image

3D case:
image

src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Engine.Impl/Variables.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
@gc46
Copy link
Contributor Author

gc46 commented Sep 1, 2022

To-Do: Figure out how to resolve merge conflicts

Copy link
Member

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/MIDebugEngine/Natvis.Impl/Natvis.cs Outdated Show resolved Hide resolved
@WardenGnaw WardenGnaw merged commit 7983eaa into main Sep 9, 2022
@WardenGnaw WardenGnaw deleted the dev/gabchen/user-story-1556891 branch September 9, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants