-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeout for slow terminal #965
Conversation
@Epikem Thank you for your submission. Can you tell me what you tested so know what else needs to be tested? |
My Environment:
Followed this step to debug. I checked the error(timeout) happened here does not appear with increased delay. This is vscode debug console log when timeout happened:
And This is when timeout does not happen (after increase delay):
Other files in
...
{
"name": "(gdb) Launch",
"type": "cppdbg",
"request": "launch",
"preLaunchTask": "buildcpp",
"program": "${fileDirname}/${fileBasenameNoExtension}.exe",
"args": [
"<${fileDirname}/input.txt"
],
"stopAtEntry": false,
"cwd": "${workspaceFolder}",
"environment": [
],
"logging":{
"engineLogging": true,
"trace":true
},
"externalConsole": false,
"MIMode": "gdb",
"miDebuggerPath": "D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/bin/gdb.exe",
"setupCommands": [
{
"description": "Enable pretty-printing for gdb",
"text": "-enable-pretty-printing",
"ignoreFailures": true,
}
]
}
...
{
"configurations": [
{
"name": "gcc",
"includePath": [
"${workspaceFolder}/**",
"D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/include",
"D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/**"
],
"defines": [
"_DEBUG",
"UNICODE",
"_UNICODE"
],
"compilerPath": "\"D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/bin/g++.exe\"",
"cStandard": "c11",
"cppStandard": "c++17",
"intelliSenseMode": "gcc-x64",
"browse": {
"path": [
"${workspaceRoot}",
"D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/include",
"D:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include"
],
"limitSymbolsToIncludedHeaders": false,
"databaseFilename": ""
},
"compilerArgs": [
"-g"
]
}
],
"version": 4
}
{
"version": "2.0.0",
"tasks": [
{
"label": "msvc build",
"type": "shell",
"command": "cl.exe",
"args": [
"/EHsc",
"/Zi",
"/Fe:",
"./sport/cpp/main.exe",
"./sport/cpp/main.cpp"
],
"group": "build",
"presentation": {
"reveal": "always"
},
"problemMatcher": "$msCompile"
},
{
"label": "buildcpp",
"command": "g++",
"args": [
"${file}",
"-g",
"-o",
"${fileDirname}/${fileBasenameNoExtension}"
],
"group": {
"kind": "build",
"isDefault": true
},
"problemMatcher": {
"fileLocation": [
"relative",
"${workspaceRoot}"
],
"pattern": {
"regexp": "^(.*):(\\d+):(\\d+):\\s+(warning error):\\s+(.*)$",
"file": 1,
"line": 2,
"column": 3,
"severity": 4,
"message": 5
}
}
}
]
} |
Thanks! |
Slow terminals like powershell with profile sometimes timeouts (microsoft/vscode-cpptools#2889). Also wait time does not seem to match with comment so I suggest increasing wait time.
Also adding
Error_TimeoutWaitingForConnection
to error message could be better (line 186).