Disallow ! characters in tunable parameter names. (#641)

Follow on to #617
microsoft · Jan 19, 2024 · b531400 · b531400
1 parent 36d2e67
commit b531400
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/mlos_bench/mlos_bench/config/schemas/tunables/tunable-params-schema.json b/mlos_bench/mlos_bench/config/schemas/tunables/tunable-params-schema.json
@@ -136,7 +136,8 @@
         "tunable_params_set": {
             "type": "object",
             "patternProperties": {
-                "^.+$": {
+                "^[^!]+$": {
+                    "$comment": "`!` characters are not currently allowed in tunable parameter names.",
                     "$ref": "#/$defs/tunable_param"
                 }
             },

diff --git a/.../tests/config/schemas/tunable-params/test-cases/bad/invalid/tunable-params-bad-name.jsonc b/.../tests/config/schemas/tunable-params/test-cases/bad/invalid/tunable-params-bad-name.jsonc
@@ -0,0 +1,12 @@
+{
+    "covariant_group_name-1": {
+        "cost": 1,
+        "params": {
+            "bad-!-char-in-name": {
+                "type": "categorical",
+                "default": "foo",
+                "values": ["foo", "bar"]
+            }
+        }
+    }
+}