Convert - to _ in parse_extras

microsoft · Aug 19, 2024 · d53fdbc · d53fdbc
1 parent 8afe9c3
commit d53fdbc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/mlos_bench/mlos_bench/launcher.py b/mlos_bench/mlos_bench/launcher.py
@@ -399,6 +399,10 @@ def _try_parse_extra_args(cmdline: Iterable[str]) -> Dict[str, TunableValue]:
             # Handles missing trailing elem from last --key arg.
             raise ValueError("Command line argument has no value: " + key)
 
+        # Convert "max-suggestions" to "max_suggestions" for compatibility with
+        # other CLI options to use as common python/json variable replacements.
+        config = {k.replace("-", "_"): v for k, v in config.items()}
+
         _LOG.debug("Parsed config: %s", config)
         return config
 

diff --git a/mlos_bench/mlos_bench/tests/launcher_in_process_test.py b/mlos_bench/mlos_bench/tests/launcher_in_process_test.py
@@ -31,7 +31,7 @@
                 "mlos_bench/mlos_bench/tests/config/cli/mock-opt.jsonc",
                 "--trial_config_repeat_count",
                 "3",
-                "--max_suggestions",
+                "--max-suggestions",
                 "3",
                 "--mock_env_seed",
                 "42",  # Noisy Mock Environment.