Allow empty tunable values to represent the defaults

microsoft · Oct 4, 2024 · d826346 · d826346
1 parent df8eac0
commit d826346
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json b/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json
@@ -12,7 +12,6 @@
                     "type": ["string", "number", "boolean"]
                 }
             },
-            "minProperties": 1,
             "not": {
                 "required": ["tunable_values"]
             }

diff --git a/.../config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc b/.../config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc
@@ -1,4 +1,6 @@
 {
+    "$schema": "https://raw.githubusercontent.com/microsoft/MLOS/main/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json",
+
     "foo": "bar",
     "int": 1,
     "float": 1.1,

diff --git a/...config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc b/...config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc
@@ -0,0 +1,4 @@
+{
+    "$schema": "https://raw.githubusercontent.com/microsoft/MLOS/main/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json"
+    // empty tunable values represents the defaults
+}
diff --git a/.../schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc b/.../schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc
@@ -0,0 +1,3 @@
+{
+    // empty tunable values represents the defaults
+}