You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LlamaTuneAdapter.inverse_transform() apparently produces small float values like 1.5 and 0.998 and assigns them to int hyperparameters with range [1, 10000].
If we add validation immediately after producing such config, it will fail, causing the corresponding unit test failure:
FAILED mlos_bench/mlos_bench/tests/optimizers/llamatune_opt_test.py::test_llamatune_optimizer - ConfigSpace.exceptions.IllegalValueError: Value 1.5: (<class 'float'>) is not allowed for hyperparameter dim_0, Type: UniformInteger, Range: [1, 10000], Default: 5000
Interestingly, in ConfigSpace 1.0 same float inputs get scaled up from [0, 1] to int range of the corresponding hyperparameter. That also produces invalid configuration because value of 1.5 got scaled to 15000, i.e., outside of the hyperparameter's [1, 10000] range.
The text was updated successfully, but these errors were encountered:
Summary of changes:
* [x] Update dependencies to ConfigSpace >= 1.0.
* [x] Update dependencies to SMAC3 >= 2.2.
* [x] Migrate to new ConfigSpace API.
* [x] Better definition of ConfigSpace fixture in unit tests.
* [x] Fix mypy and pylint issues triggered by the migration.
Notes:
* Side effect: **Works with Python 3.12!**
* ~Supersedes #799~
* ~Depends on upcoming SMAC3 release with [SMAC3
#1124](automl/SMAC3#1124) merged in and a new
release cut with it.~
* Quantization will be added back later:
* #803
* ~Tests fail due to LlamaTune issue:~
* #805Closes#727
---------
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@microsoft.com>
LlamaTuneAdapter.inverse_transform()
apparently produces smallfloat
values like1.5
and0.998
and assigns them toint
hyperparameters with range[1, 10000]
.If we add validation immediately after producing such config, it will fail, causing the corresponding unit test failure:
FAILED mlos_bench/mlos_bench/tests/optimizers/llamatune_opt_test.py::test_llamatune_optimizer - ConfigSpace.exceptions.IllegalValueError: Value 1.5: (<class 'float'>) is not allowed for hyperparameter dim_0, Type: UniformInteger, Range: [1, 10000], Default: 5000
Interestingly, in ConfigSpace 1.0 same
float
inputs get scaled up from[0, 1]
toint
range of the corresponding hyperparameter. That also produces invalid configuration because value of1.5
got scaled to15000
, i.e., outside of the hyperparameter's[1, 10000]
range.The text was updated successfully, but these errors were encountered: