Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log scale and quantization to the tunables #662

Merged
merged 37 commits into from
Feb 6, 2024
Merged

Add log scale and quantization to the tunables #662

merged 37 commits into from
Feb 6, 2024

Conversation

motus
Copy link
Member

@motus motus commented Feb 2, 2024 •
edited by bpkroth
Loading

Closes #664

motus added 24 commits January 18, 2024 17:17
@motus
add weights support to teh Tunable and the JSON schema
8f59f5a
@motus
typo: use "number" instead of "float" in JSON schema
996cc9a
@motus
add unit tests for weighted parameters of the tunables; check for
afc41e2 
negative weights
@motus
bugfix: incorrect formatting of intyerpolated JSON strings in the unit
cf3d19e 
tests
@motus
check for zero weights (this is ok)
e143928
@motus
pass weights from Tunable to ConfigSpace hyperparameters
4503689
@motus
update the weights in unit tests to make FLAML optimizer happy
4341df1
@motus
specify probabilities in the config space unit tests
845c700
@motus
Merge branch 'main' into sergiym/tunable/weights
cda0694
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/tunable…
528a094 
…/weights
@motus
Merge branch 'sergiym/tunable/weights' of github.com:motus/MLOS into …
33e86af 
…sergiym/tunable/weights
@motus
Merge branch 'main' into sergiym/tunable/weights
c756f55
@motus
Merge branch 'main' into sergiym/tunable/weights
54f816f
@motus
Merge branch 'main' into sergiym/tunable/weights
56e5ddd
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/tunable…
025b55a 
…/weights
@motus
Merge branch 'main' into sergiym/tunable/weights
3514fa2
@motus
Merge branch 'main' of github.com:microsoft/MLOS into sergiym/tunable…
eecbc7f 
…/weights
@motus
add a range_weight property
b30950c
@motus
move range weight to a special parameter
0b6d21a
@motus
minor fix for pylint
fdeaad0
@motus
add quantization points and log scale to the tunables and pass this d…
61143e3 
…ata all the way to ConfigSpace
@motus
add new test cases
fd072e9
@motus
add log to some tunables in the unit tests
8500d67
@motus
add more unit tests for new tunable's properties
4bcd84b
@motus motus added enhancement New feature or request WIP Work in progress - do not merge yet mlos-bench labels Feb 2, 2024
@motus motus self-assigned this Feb 2, 2024
@motus motus mentioned this pull request Feb 2, 2024
Merged
@motus motus added ready for review Ready for review and removed WIP Work in progress - do not merge yet labels Feb 2, 2024
@motus motus marked this pull request as ready for review February 2, 2024 21:33
@motus motus requested a review from a team as a code owner February 2, 2024 21:33
@motus motus enabled auto-merge (squash) February 5, 2024 21:10
@motus motus disabled auto-merge February 5, 2024 21:10
@motus motus enabled auto-merge (squash) February 5, 2024 21:10
bpkroth
bpkroth approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@motus motus merged commit 4d7e08f into microsoft:main Feb 6, 2024
11 of 12 checks passed
motus added a commit that referenced this pull request Feb 7, 2024
@motus @bpkroth
Add support for ConfigSpace distributions (#663)
3458c66 
To be merged after #662 

Closes #665

---------

Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Co-authored-by: Brian Kroth <bpkroth@microsoft.com>
@motus motus deleted the sergiym/tunable/quant_log branch February 8, 2024 00:02
@bpkroth bpkroth mentioned this pull request Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
enhancement New feature or request mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support log scale and quantization of numeric range of the Tunables
2 participants
@motus @bpkroth