Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluggable Scheduler #710

Merged
merged 45 commits into from
Mar 15, 2024
Merged

Pluggable Scheduler #710

merged 45 commits into from
Mar 15, 2024

Conversation

motus
Copy link
Member

@motus motus commented Mar 9, 2024 •
edited by bpkroth
Loading

  • Make Scheduler class loadable from JSON configs
  • Update the Launcher and run.py to instantiate Scheduler from JSON
  • Create JSON schema for the Scheduler config
  • Add unit tests for the new Scheduler JSON configs

Closes #700

@motus motus added WIP Work in progress - do not merge yet mlos-bench labels Mar 9, 2024
@motus motus self-assigned this Mar 9, 2024
@motus motus marked this pull request as ready for review March 11, 2024 22:06
@motus motus requested a review from a team as a code owner March 11, 2024 22:06
@motus motus added the ready for review Ready for review label Mar 11, 2024
@motus motus removed the WIP Work in progress - do not merge yet label Mar 15, 2024
motus and others added 2 commits March 15, 2024 13:27
@motus @bpkroth
Update mlos_bench/mlos_bench/launcher.py
8070c30 
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
@bpkroth
pylint
f395531
@bpkroth bpkroth mentioned this pull request Mar 15, 2024
Open
bpkroth
bpkroth approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bpkroth bpkroth mentioned this pull request Mar 15, 2024
Closed
4 tasks
@motus motus merged commit 4166e96 into microsoft:main Mar 15, 2024
12 checks passed
@motus motus deleted the sergiym/run/scheduler_load branch March 15, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees

@motus motus

Labels
mlos-bench ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config support for pluggable Schedulers
2 participants
@motus @bpkroth