UTC datetime handling improvements #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motus
added
WIP
|
I started hacking on this a little locally as well. Will post a PR against yours in a bit... |
bpkroth
force-pushed
the
sergiym/datetime/utc
branch
from
274a020
to
08c3180
Compare
Enforce storage/retrieval conversion to UTC (retry)
bpkroth
changed the title
bpkroth
reviewed
Mar 18, 2024
bpkroth
added
ready for review
motus
commented
Mar 19, 2024
Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some deprecation warnings about use of
datetime.utcnow().Additionally, sqlite does not store timezone info even if provided, so retrieving the data may be interpreted according to the host machine's local timezone, which may or may not be UTC.
To mitigate this, this change ensures that all timestamps are
Additionally, we expand the tests to check for this behavior, first with some additional conversion matrixes when telemetry or status data is received in implicit local vs. explicit timezone data as well as executions where the implicit local timezone has be overridden with a
TZenvironment variable, to simulate different default timezone hosts.Closes #718