-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple objectives in the optimizer config #725
Merged
bpkroth
merged 33 commits into
microsoft:main
from
motus:sergiym/opt/multiobjective_config
Apr 30, 2024
Merged
Allow multiple objectives in the optimizer config #725
bpkroth
merged 33 commits into
microsoft:main
from
motus:sergiym/opt/multiobjective_config
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when loading the results
…led trials into the optimizer
…to sergiym/opt/multiobjective
motus
changed the title
Allow multiple objectives in optimizer config
Allow multiple objectives in the optimizer config
Mar 28, 2024
4 tasks
bpkroth
reviewed
Apr 29, 2024
mlos_bench/mlos_bench/config/schemas/cli/common-defs-subschemas.json
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Apr 29, 2024
mlos_bench/mlos_bench/config/schemas/optimizers/optimizer-schema.json
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Apr 29, 2024
bpkroth
reviewed
Apr 29, 2024
bpkroth
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a slight naming change, otherwise LGTM
bpkroth
reviewed
Apr 29, 2024
...s_bench/tests/config/schemas/optimizers/test-cases/bad/invalid/bad_optimization_target.jsonc
Outdated
Show resolved
Hide resolved
…/opt/multiobjective_config
…MLOS into sergiym/opt/multiobjective_config
Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
…MLOS into sergiym/opt/multiobjective_config
…t/optimization_direction config
bpkroth
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
motus
added a commit
that referenced
this pull request
May 9, 2024
* [x] Store multiple optimization targets and directions in base `Optimizer` class * [x] Support multiple optimization targets in mock and grid search optimizers * [x] Check for single objective in `MlosCoreOptimizer` class (will add support for multiple objectives after implementing that feature in `mlos_core` in subsequent PRs) * [x] Update unit tests in mlos_bench Merge after ~#723~ and ~#725~ --------- Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"optimizer_target": {"score": "min"}
formatNotImplementedError
if > 1 target)Part of #692
Merge after #723