Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups to example notebook for new APIs #834

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Aug 6, 2024

  • enable notebook execution in CI pipelines to prevent these mistakes in the future

@bpkroth
Copy link
Contributor Author

bpkroth commented Aug 6, 2024

Need something like the following next:

make notebook-test
# which runs in the CI pipeline
# and does something like the following
find . -name '*.ipynb' -print0 | xargs -t -P0 -0 -n1 python -m jupyter execute

@bpkroth bpkroth marked this pull request as ready for review August 7, 2024 22:02
@bpkroth bpkroth requested a review from a team as a code owner August 7, 2024 22:02
@bpkroth
Copy link
Contributor Author

bpkroth commented Aug 7, 2024

Should really enable this for some of the example repos as well.

@motus motus merged commit a4d21cd into microsoft:main Aug 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants