Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include realistic test scenarios #74

Closed
algattik opened this issue Sep 27, 2019 · 2 comments
Closed

Include realistic test scenarios #74

algattik opened this issue Sep 27, 2019 · 2 comments

Comments

@algattik
Copy link
Contributor

algattik commented Sep 27, 2019 •
edited
Loading

The template should include realistic test scenarios, in order to illustrate a proper test strategy and help deal with technical aspects (e.g. folder organization for pytest).

  • Unit tests - the current code_test.py doesn't test the actual code in code/, including mocks
  • Integration tests if applicable (e.g. connectivity to data marts)
  • Smoke test of the deployed ACI container in staging before deploying to AKS
@algattik algattik changed the title Include realistic test and integration scenarios Include realistic test scenarios Sep 27, 2019
@algattik algattik mentioned this issue Nov 28, 2019
Merged
algattik added a commit to algattik/MLOpsPython that referenced this issue Nov 28, 2019
@algattik
Simplified build with Azure CLI; various bugfixes
9860764 
* Use Azure CLI tasks to remove need for variables SP_APP_ID, SP_APP_SECRET, SUBSCRIPTION_ID, TENANT_ID
* Updated gettin_started.md to point out variable path to artifact (microsoft#117)
* Made random hyperparameter (ridge regression alpha) a pipeline parameter, setting its value in the DevOps pipeline (microsoft#107)
* Changed unit test to test actual training code (partially solves microsoft#74)
* Fixed: attach_compute should set exit code after exception (microsoft#113)
* Fixed scoring endpoint HTTP behavior (microsoft#110)
* Fixed PipelineParameters format in call to Azure ML Extension (microsoft#118)
* Fixed Model build environment for Azure Web App for containers (microsoft#119)
@algattik algattik mentioned this issue Nov 28, 2019
Merged
@dtzar
Copy link
Member

dtzar commented Dec 9, 2019

@algattik Considering you updated unit test space and added the smoke test and there is no data integration test (i.e. due to lack of #75) - would it be fair to you to close this item out now? Could add a separate issue for the data integration tests once 75 is implemented.

@algattik
Copy link
Contributor Author

algattik commented Dec 9, 2019

Agree, data connection related tests belong in #75.

@algattik algattik closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtzar @algattik