-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage environments in conda YAML files #158
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f69a2ca
Merge pull request #2 from microsoft/master
algattik 7b370c1
Merge remote-tracking branch 'upstream/master'
algattik 3ab3230
Merge branch 'master' of https://github.com/microsoft/MLOpsPython
algattik c840623
.
algattik c2b953f
.
algattik bceeba6
Update code_test.py
algattik 897b7d4
.
algattik e304fd2
Update Dockerfile
algattik 41c2499
Do not use conda-merge
algattik 963b36a
Merge remote-tracking branch 'upstream/master' into algattik/conda-envs
algattik 921b65f
PR review fixes
algattik 2956ada
Merge remote-tracking branch 'upstream/master'
algattik b05c3b7
Update Dockerfile
algattik 7124f5c
Merge branch 'master' into algattik/conda-envs
algattik 1cc78b7
Merge remote-tracking branch 'upstream/master' into algattik/conda-envs
algattik de72bde
PR review fixes
algattik 568bdee
Update training_dependencies.yml
algattik f590807
Update code_test.py
algattik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,7 @@ ENV/ | |
env.bak/ | ||
venv.bak/ | ||
*.vscode | ||
condaenv.* | ||
|
||
# Spyder project settings | ||
.spyderproject | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: mlopspython_ci | ||
|
||
dependencies: | ||
|
||
# The python interpreter version. | ||
- python=3.7.5 | ||
|
||
- r=3.6.0 | ||
- r-essentials=3.6.0 | ||
- numpy=1.18.1 | ||
- pandas=1.0.0 | ||
- scikit-learn=0.22.1 | ||
|
||
- pip=20.0.2 | ||
- pip: | ||
|
||
# dependencies shared with other environment .yml files. | ||
- azureml-sdk==1.0.79 | ||
|
||
# Additional pip dependencies for the CI environment. | ||
- pytest==5.3.1 | ||
- pytest-cov==2.8.1 | ||
- requests==2.22.0 | ||
- python-dotenv==0.10.3 | ||
- flake8==3.7.9 | ||
- flake8_formatter_junit_xml==0.0.6 | ||
- azure-cli==2.0.77 | ||
- tox==3.14.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
entryScript: score.py | ||
runtime: python | ||
condaFile: conda_dependencies.yml | ||
condaFile: ../scoring_dependencies.yml | ||
extraDockerfileSteps: | ||
schemaFile: | ||
sourceDirectory: | ||
enableGpu: False | ||
baseImage: | ||
baseImageRegistry: | ||
baseImageRegistry: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
name: diabetes_training | ||
|
||
dependencies: | ||
|
||
# The python interpreter version. | ||
- python=3.7.5 | ||
|
||
- numpy=1.18.1 | ||
- pandas=1.0.0 | ||
- scikit-learn=0.22.1 | ||
#- r-essentials | ||
#- tensorflow | ||
#- keras | ||
|
||
- pip=20.0.2 | ||
- pip: | ||
- azureml-core==1.0.79 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this container with r_essentails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had it essentially to demonstrate the use of the container for training
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added to the doc instead:
I think it's a much more robust solution, and guides R users to the right process for adding the additional packages they will usually need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, training seems to run fine:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with you and that's what we showcased in python training pipeline and for R we wanted to demonstrate that one can bring in their base image for training as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to showcase it, I think it's better to do that in a doc than buried in a script