-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No pkl extension requirement for model name #164
Conversation
I see the following issues:
A cleaner approach might be to use Model.get_model_path(), which directly returns the file name, is compact and can be used in multi model deployment. The downside is that it requires the model name to be hard-coded (or we could define an environment variable in the AML Environment). I think a better approach until we enable Environments, might be to keep the original code and remove the |
@algattik what about this one (just updated)? It will work in all cases for single model, and I can use my favorite name now rather than to use undocumented pkl extension:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. Suggesting a change to be more future-proof (only the "end" of the path is documented"
Co-Authored-By: Alexandre Gattiker <algattik@users.noreply.github.com>
I would like to have a model name with no pickle extension