Fixed and rearranged unit tests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjcmit
commented
Feb 8, 2020
•
bjcmit
commented
- Fixed test_train_model test in code_test.py
- Renamed code_test.py to train_test.py
- Moved train_test.py under diabetes_regression directory
- Moved data_test.py under data directory
- Added lint and unit test tasks to azdo-base-pipeline.yml
- Deleted lint-and-test.sh and tox.ini
- Renamed code_test.py to train_test.py - Moved train_test.py under diabetes_regression directory - Moved data_test.py under data directory - Added lint and unit test tasks to azdo-base-pipeline.yml - Deleted lint-and-test.sh and tox.ini
bjcmit
changed the title
dtzar
suggested changes
Feb 8, 2020
There was a problem hiding this comment.
- Please remove tox from dependencies
- Remove reference to tox in getting started
…crosoft/MLOpsPython into brysmith/fix_test_train_model
|
@bjcmit now that you have moved the test files to the respective project directory. Would you like to consider deleting the folder at the root? |
|
Build fails lint |
Yes, we should remove that root test/unit directory. I believe if you delete init.py there it should go away. |
dtzar
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.