Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary clarifying comments #187

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Canary clarifying comments #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/canary_ab_deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Having the Istio installed, figure out the Istio gateway endpoint on your K8s cl
GATEWAY_IP=$(kubectl get svc istio-ingressgateway -n istio-system -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
```

You don't need to create any Istio resources (e.g. Gateway or VirtualService) at this point. It will be handled by the AzDo pipeline that builds and deploys a scoring image.

#### 2. Set up variables

There are some extra variables that you need to setup in ***devopsforai-aml-vg*** variable group (see [getting started](./getting_started.md)):
Expand All @@ -35,7 +37,7 @@ The result of the pipeline will be a registered Docker image in the ACR reposito

![scoring image](./images/scoring_image.png)

The pipeline will also deploy the scoring image to the Kubernetes cluster.
The pipeline creates Istio Gateway and VirtualService and deploys the scoring image to the Kubernetes cluster.

```bash
kubectl get deployments --namespace abtesting
Expand Down