bootstrap diabetes cleanup #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcare
reviewed
Feb 12, 2020
eedorenko
approved these changes
Feb 12, 2020
tcare
approved these changes
Feb 12, 2020
| def replaceprojectname(project_dir, project_name, rename_name): | ||
| # Replace instances of rename_name within files with project_name | ||
| dirs = [r".env.example", | ||
| r".pipelines\azdo-base-pipeline.yml", |
There was a problem hiding this comment.
\ won't work for xplat, might be out of scope for this PR.
| @@ -57,38 +57,6 @@ def deletedir(self): | |||
| os.system( | |||
| 'rmdir /S /Q "{}"'.format(os.path.join(self._project_directory, dir))) # NOQA: E501 | |||
There was a problem hiding this comment.
rmdir won't work for xplat, probably out of scope for this PR.
| fin.write(data) | ||
| fin.close() | ||
|
|
||
|
|
||
| def main(args): | ||
| parser = argparse.ArgumentParser(description='New Template') | ||
| parser.add_argument("--d", type=str, |
There was a problem hiding this comment.
We should also stick to the standard of -d or --directory, same for below
| @@ -108,6 +76,40 @@ def validateargs(self): | |||
| raise Exception("Project name should be 3 to 15 chars long") | |||
There was a problem hiding this comment.
Now that we're replacing more things, I think our valid set of chars might be reduced. \w and _ are probably it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all remaining traces of the word "diabetes" in the code base.