Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started fixes for the Variable Group section #221

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

tcare
Copy link
Contributor

@tcare tcare commented Mar 4, 2020

Some fixes based on Eugene's feedback.

  • Ordered the descriptions to match the table
  • Added ACI description
  • Added location description and link
  • Fixed ACI acronym description

Additional changes

  • Added a clarification that the variables with Azure resource names don't have to exist yet
  • Removed 'diabetes' from the name of ACI and AKS deployments and switched to generic 'mlops' to match the other resource naming convention

Some fixes based on Eugene's feedback.
- Ordered the descriptions to match the table
- Added ACI description
- Added location description and link
- Fixed ACI acronym description

Additional changes
- Added a clarification that the variables with Azure resource names don't have to exist yet
- Removed 'diabetes' from the name of ACI and AKS deployments and switched to generic 'mlops' to match the other resource naming convention
@tcare tcare requested a review from eedorenko March 4, 2020 17:57
@tcare tcare merged commit 5966d3d into master Mar 4, 2020
@tcare tcare deleted the tcare/gs-var-fixes branch March 4, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants