Sudivate dockertag #240
Merged
Sudivate dockertag #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedorenko
suggested changes
Mar 25, 2020
| @@ -7,12 +7,14 @@ to run test and deployment code. | |||
| `mcr.microsoft.com/mlops/python:latest` is built with this | |||
| [Dockerfile](../environment_setup/Dockerfile). | |||
|
|
|||
| **Note:** Additionally mcr.microsoft.com/mlops/python image is also tagged with amlsdk[version] e.g amlsdk1.1.5.1 and githubrelease[version] e.g. githubrelease131681 which helps in tracking the exact version of amlsdk and other python dependencies included in the image. | |||
|
|
|||
There was a problem hiding this comment.
Is 131681 release number?
Can we go with just mcr.microsoft.com/mlops/python:[githubreleaseversion] (e.g. mcr.microsoft.com/mlops/python:3.0.0) instead of mcr.microsoft.com/mlops/python:githubrelease[version]
(e.g. mcr.microsoft.com/mlops/python:githubreleaseversion3.0.0) ?
There was a problem hiding this comment.
amlsdk-[version]
githubreleaseversion-[version]
eedorenko
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191