Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer explanation of the pipeline stages in the getting started guide #247

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Clearer explanation of the pipeline stages in the getting started guide #247

merged 1 commit into from
Mar 31, 2020

Conversation

jotaylo
Copy link
Contributor

@jotaylo jotaylo commented Mar 31, 2020

At the moment we're explaining the pipeline stages in paragraph form, this change breaks it out into bullet points and reduces unnecessary verbosity

@jotaylo jotaylo requested a review from tcare March 31, 2020 17:08
tcare
tcare approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@tcare tcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel too strongly about it, but it might be good to convey that the listed pipeline stages are in order. We conveyed order in the paragraph form.

I really like this approach btw! Much more readable.

@jotaylo jotaylo merged commit 27afdbb into master Mar 31, 2020
@dtzar dtzar deleted the jotaylo/gss branch April 9, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcare tcare tcare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jotaylo @tcare