Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for emitting darknet models #409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Sep 12, 2018

Implements the following layers for darknet:

  • Convolution
  • Relu
  • LeakyRelu
  • PRelu (not currently supported by upstream)
  • Max pooling
  • Avg pooling
  • Concat
  • Softmax
  • Squeeze
  • Flatten
  • Dropout
  • FullyConnected

Having some issues with the testing side, some cases the SNR doesn't agree with the threshold.

@namizzz
Copy link
Contributor

namizzz commented Sep 13, 2018

Hi @fran6co ,thanks very much! Have you test the accuracy of the conversion to darknet? We have implemented a set of test tools and error tolerance . Could you please add some test scripts to test the accuracy of your code ?

@fran6co
Copy link
Contributor Author

fran6co commented Sep 13, 2018

Hi @namizzz, I couldn't find a darknet python package for testing it using MMdnn scripts. It's a simple C library so in theory is just enough to have the library somewhere and use ctypes, do you have suggestions how to integrate it to MMdnn?

@namizzz
Copy link
Contributor

namizzz commented Sep 13, 2018

@fran6co fran6co force-pushed the darknet_emitter branch 14 times, most recently from 7bdaf86 to ae74ef2 Compare September 18, 2018 13:50
@kitstar
Copy link
Contributor

kitstar commented Sep 19, 2018

Hi @fran6co Thanks for the contributeing! Do you have time to finish some unimplement ops in darknet emitter, like "Flatten", "FullyConnected" and "Dropout"? Thanks!

@fran6co
Copy link
Contributor Author

fran6co commented Sep 19, 2018

@kitstar yes, I'm slowly working through the errors in the tests. I'm not sure why it's failing on the SNR for some of them.

@fran6co fran6co force-pushed the darknet_emitter branch 2 times, most recently from 02c4123 to 53deae2 Compare September 19, 2018 15:04
@fran6co
Copy link
Contributor Author

fran6co commented Sep 19, 2018

@kitstar just implemented those extra layers but it's still failing, it seems to be failing even worse now but because of some network issues instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants