Update Code and Fixed Some Warning ⚠

Assets/MRTK/Providers/WindowsMixedReality/XRSDK/WindowsMixedRealityEyeGazeDataProvider.cs

@@ -84,7 +84,8 @@ public override void Enable()
                 EnableIfLoaderBecomesActive();
                 return;
             }
-            else if (!IsActiveLoader.Value)
+
+            if (!IsActiveLoader.Value)
             {
                 IsEnabled = false;
                 return;
@@ -96,7 +97,7 @@ public override void Enable()
         private async void EnableIfLoaderBecomesActive()
         {
             await new WaitUntil(() => IsActiveLoader.HasValue);
-            if (IsActiveLoader.Value)
+            if (IsActiveLoader != null && IsActiveLoader.Value)
             {
                 Enable();
             }

Assets/MRTK/SDK/Features/UX/Scripts/HandCoach/MoveToTarget.cs

@@ -34,7 +34,7 @@ public GameObject TrackingObject
         /// <summary>
         /// Target to move to.
         /// </summary>
-        public GameObject TargetObject
+        private GameObject TargetObject
         {
             get
             {
@@ -54,7 +54,7 @@ public GameObject TargetObject
         /// <summary>
         /// Shared parent between tracking and target objects used for relative local positions.
         /// </summary>
-        public GameObject RootObject
+        private GameObject RootObject
         {
             get
             {
@@ -73,7 +73,7 @@ public GameObject RootObject
         /// <summary>
         /// Duration of move from tracking object to target object in seconds.
         /// </summary>
-        public float Duration
+        private float Duration
         {
             get
             {
@@ -92,7 +92,7 @@ public float Duration
         /// <summary>
         /// Tunable offset to get the GameObject to arrive at the right target position.
         /// </summary>
-        public Vector3 TargetOffset
+        private Vector3 TargetOffset
         {
             get
             {
@@ -111,7 +111,7 @@ public Vector3 TargetOffset
         /// <summary>
         /// Lerp curve that controls the animation position over time from the trackingObject to the targetObject.
         /// </summary>
-        public AnimationCurve AnimationCurve
+        private AnimationCurve AnimationCurve
         {
             get
             {

Assets/MRTK/SDK/Features/UX/Scripts/HandCoach/RotateAroundPoint.cs

@@ -15,7 +15,7 @@ public class RotateAroundPoint : MonoBehaviour
         /// <summary>
         /// Parent object centered at rotation center.
         /// </summary>
-        public Transform CenteredParent
+        private Transform CenteredParent
         {
             get
             {
@@ -34,7 +34,7 @@ public Transform CenteredParent
         /// <summary>
         /// Hand hint parent to rotate inverse to centeredParent to keep hand orientation the same.
         /// </summary>
-        public Transform InverseParent
+        private Transform InverseParent
         {
             get
             {
@@ -53,7 +53,7 @@ public Transform InverseParent
         /// <summary>
         /// Point to start movement at.
         /// </summary>
-        public Transform PivotPosition
+        private Transform PivotPosition
         {
             get
             {
@@ -72,7 +72,7 @@ public Transform PivotPosition
         /// <summary>
         /// Duration of rotation around the CenteredParent in seconds.
         /// </summary>
-        public float Duration
+        private float Duration
         {
             get
             {
@@ -91,7 +91,7 @@ public float Duration
         /// <summary>
         /// Lerp curve that controls the animation rotation over time.
         /// </summary>
-        public AnimationCurve AnimationCurve
+        private AnimationCurve AnimationCurve
         {
             get
             {
@@ -110,7 +110,7 @@ public AnimationCurve AnimationCurve
         /// <summary>
         /// How many degrees to rotate along each axis.
         /// </summary>
-        public Vector3 RotationVector
+        private Vector3 RotationVector
         {
             get
             {

Assets/MRTK/SDK/Features/UX/Scripts/Loader/LoaderController.cs

@@ -196,10 +196,8 @@ private float Cycles
                 {
                     return (frequency < 0.0f) ? (Time.time / 0.000001f) * -1.0f : (Time.time / frequency) * -1.0f;
                 }
-                else
-                {
-                    return (frequency < 0.0f) ? Time.time / 0.000001f : Time.time / frequency;
-                }
+
+                return (frequency < 0.0f) ? Time.time / 0.000001f : Time.time / frequency;
             }
         }
 
@@ -209,13 +207,9 @@ private float Cycles
 
         private Transform dot01;
         private Vector3 dot01NewPos = Vector3.zero;
-        private Vector3 dot01NewScale = Vector3.zero;
-        private Vector3 dot01NewRot = Vector3.zero;
 
         private Transform dot02;
         private Vector3 dot02NewPos = Vector3.zero;
-        private Vector3 dot02NewScale = Vector3.zero;
-        private Vector3 dot02NewRot = Vector3.zero;
 
         private const float tau = Mathf.PI * 2.0f;
 

Assets/MRTK/SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs

@@ -79,7 +79,7 @@ public abstract class BaseControllerPointer : ControllerPoseSynchronizer, IMixed
         /// </summary>
         /// <remarks>This <see href="https://docs.unity3d.com/ScriptReference/GameObject.html">GameObject</see> must have a <see cref="Microsoft.MixedReality.Toolkit.Input.IMixedRealityCursor"/> attached to it.</remarks>
         /// <param name="newCursor">The new cursor</param>
-        public virtual void SetCursor(GameObject newCursor = null)
+        private void SetCursor(GameObject newCursor = null)
         {
             using (SetCursorPerfMarker.Auto())
             {
@@ -340,7 +340,7 @@ public virtual bool IsInteractionEnabled
         /// <summary>
         /// Maximum distance at which all pointers can collide with a <see href="https://docs.unity3d.com/ScriptReference/GameObject.html">GameObject</see>, unless it has an override extent.
         /// </summary>
-        public float PointerExtent
+        protected float PointerExtent
         {
             get
             {
@@ -368,7 +368,7 @@ public float PointerExtent
         /// <summary>
         /// The length of the pointer when nothing is hit.
         /// </summary>
-        public float DefaultPointerExtent
+        protected float DefaultPointerExtent
         {
             get => Mathf.Min(defaultPointerExtent, PointerExtent);
             set => defaultPointerExtent = value;
@@ -389,7 +389,7 @@ public float DefaultPointerExtent
         /// <summary>
         /// Ray stabilizer used when calculating position of pointer end point.
         /// </summary>
-        public IBaseRayStabilizer RayStabilizer { get; set; }
+        protected IBaseRayStabilizer RayStabilizer { get; set; }
 
         /// <inheritdoc />
         public virtual SceneQueryType SceneQueryType { get; set; } = SceneQueryType.SimpleRaycast;

Assets/MRTK/SDK/Features/UX/Scripts/Pointers/ShellHandRayPointer.cs

@@ -107,11 +107,15 @@ public override void OnPostSceneQuery()
                     wasGrabPressed = IsGrabPressed;
 
                     var currentMaterial = IsSelectPressed || IsGrabPressed ? lineMaterialSelected : lineMaterialNoTarget;
-
-                    for (int i = 0; i < LineRenderers.Length; i++)
+                    
+                    foreach (var lr in LineRenderers)
                     {
-                        var lineRenderer = LineRenderers[i] as MixedRealityLineRenderer;
-                        lineRenderer.LineMaterial = currentMaterial;
+                        var lineRenderer = lr as MixedRealityLineRenderer;
+
+                        if (lineRenderer != null)
+                        {
+                            lineRenderer.LineMaterial = currentMaterial;
+                        }
                     }
                 }
             }

Assets/MRTK/SDK/Features/UX/Scripts/Pointers/TeleportPointer.cs

@@ -232,7 +232,7 @@ protected override async void Start()
                     }
                 }
                 lateRegisterTeleport = false;
-                CoreServices.TeleportSystem.RegisterHandler<IMixedRealityTeleportHandler>(this);
+                CoreServices.TeleportSystem?.RegisterHandler<IMixedRealityTeleportHandler>(this);
             }
         }
 
@@ -245,15 +245,15 @@ protected override void OnDisable()
 
         private Vector2 currentInputPosition = Vector2.zero;
 
-        protected bool isTeleportRequestActive = false;
+        private bool isTeleportRequestActive = false;
 
         private bool lateRegisterTeleport = true;
 
         private bool canTeleport = false;
 
         private bool canMove = false;
 
-        protected Gradient GetLineGradient(TeleportSurfaceResult targetResult)
+        private Gradient GetLineGradient(TeleportSurfaceResult targetResult)
         {
             switch (targetResult)
             {