Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box of SkinnedMeshRenderer support added #10611

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Bounding box of SkinnedMeshRenderer support added #10611

merged 6 commits into from
Jun 3, 2022

Conversation

lvonasek
Copy link
Contributor

@lvonasek lvonasek commented May 24, 2022

Overview

Bounding box does not support SkinnedMeshRenderer. That makes manipulation with models using SkinneMeshRenderer very hard. This PR resolves that issue.

Changes

Added support of bounding box for SkinnedMeshRenderer

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
@lvonasek lvonasek requested a review from julenka as a code owner May 24, 2022 09:39
@ghost
Copy link

ghost commented May 24, 2022

CLA assistant check
All CLA requirements met.

@RogPodge RogPodge changed the base branch from main to releases/2.8.1 June 1, 2022 20:24
@RogPodge
Copy link
Contributor

RogPodge commented Jun 1, 2022

Thanks for the PR @lvonasek! Could you also update this code in BoundsControl? The BoundingBox has been deprecated in favor of BoundsControl for awhile now.

@lvonasek
Copy link
Contributor Author

lvonasek commented Jun 2, 2022

Thanks for the PR @lvonasek! Could you also update this code in BoundsControl? The BoundingBox has been deprecated in favor of BoundsControl for awhile now.

Code updated as requested.

@RogPodge
Copy link
Contributor

RogPodge commented Jun 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Jun 3, 2022
@RogPodge RogPodge merged commit c2098fd into microsoft:releases/2.8.1 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants