Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursors spawning at the root on initial source detection #10623

Merged
merged 1 commit into from
May 31, 2022

Conversation

keveleigh
Copy link
Contributor

Overview

Currently, the pointer uses its parent to spawn its cursor. During the initial creation flow, that logic is hit before we actually put the pointer under the playspace. With this change, the pointer is now put under the playspace immediately at creation, before the cursor is spawned.

@keveleigh keveleigh requested a review from RogPodge May 31, 2022 21:26
@keveleigh keveleigh self-assigned this May 31, 2022
@keveleigh
Copy link
Contributor Author

/azp run

@keveleigh keveleigh enabled auto-merge (squash) May 31, 2022 21:27
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@keveleigh keveleigh disabled auto-merge May 31, 2022 21:27
@keveleigh keveleigh enabled auto-merge (squash) May 31, 2022 21:27
@keveleigh keveleigh merged commit fcdf493 into microsoft:releases/2.8.1 May 31, 2022
@keveleigh keveleigh deleted the fix-root-cursors branch July 18, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants