-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OnInspectorGUI for Toolkit Inspector #10936
Update OnInspectorGUI for Toolkit Inspector #10936
Conversation
Hi @Proton-V, thanks for opening the PR. I think by adding the |
@MaxWang-MS Hello. Of course, you're right, thanks! |
Co-authored-by: MaxWang-MS <68253937+MaxWang-MS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Just curious, have you run into situations where an exception was thrown? I am wondering why you added the try catch.
I added this for future changes. And i think handling error without stop action - normal way. @MaxWang-MS |
Co-authored-by: MaxWang-MS <68253937+MaxWang-MS@users.noreply.github.com>
I don't have a super strong opinion on this, but in general I tend to use try catch when I expect things to sometimes go wrong. At the moment I don't really expect exceptions to be thrown when the profile change is initiated the correct way, so I was wondering why you added them. I don't think it hurts to keep them here though. |
Changes
Overview
Fixed micro issue with MixedRealityToolkit Inspector
Issue: error stack when we have active MixedRealityToolkit Inspector in editor and active profile is changed
Fixes