Update build logic for finding sdk #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
force-pushed
the
test-fixing-build-logic-for-finding-sdk
branch
3 times, most recently
from
dc39b70
to
8e0990c
Compare
keveleigh
force-pushed
the
test-fixing-build-logic-for-finding-sdk
branch
from
616f4ce
to
ddc8830
Compare
keveleigh
changed the title
david-c-kline
approved these changes
Nov 4, 2022
|
Thank you, this fix looks good and should resolve our issue in future builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Although parsing the folder names is still not the most robust, this is the most straight forward fix for now unless (until?) we rethink this log entirely.
Changes