Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenApiStreamReader.ReadAsync doesn't respect "leave open" setting #1581

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1579

Copy link

sonarqubecloud bot commented Mar 6, 2024

@MaggieKimani1 MaggieKimani1 merged commit 2f64478 into vnext Mar 6, 2024
10 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-stream-leave-open branch March 6, 2024 10:19
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change also needs to be implemented lines 44 and 89 for consistency.
Thanks for addressing this super fast!

@MaggieKimani1
Copy link
Contributor Author

The change also needs to be implemented lines 44 and 89 for consistency. Thanks for addressing this super fast!

Here's the PR: #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenApiStreamReader.Read/ReadAsync doesn't honour "leaveOpen"Setting
3 participants