Return -1 exit code when the document is not valid #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuraiAndras
requested review from
irvinesunday,
darrelmiller,
zengin,
coseguera,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
|
@microsoft-github-policy-service agree |
MaggieKimani1
approved these changes
Jun 7, 2024
|
Is there any info on when this will be released on NuGet? Will this be out before 2.0.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous related PR #1145 did return an exit code, but it did not use the result of the validation. This PR fixes this behavior.
This properly fixes #900 and #1141.