Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes null extension bug #1698

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fixes null extension bug #1698

merged 3 commits into from
Jun 26, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1695

@MaggieKimani1 MaggieKimani1 requested a review from baywet June 24, 2024 09:27
andrueastman
andrueastman reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can add tests/assertions for the changes for the relevant extensions in the tests?
This would probably be an inverse of the test at

OpenAPI.NET/test/Microsoft.OpenApi.Tests/MicrosoftExtensions/OpenApiReservedParameterExtensionTests.cs

Line 13 in bb9e5b5

public void Parses()

baywet
baywet previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides Andrew's comments, LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.8% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@MaggieKimani1 MaggieKimani1 merged commit ae79040 into vnext Jun 26, 2024
10 of 11 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/fix-null-extension branch June 26, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@coseguera coseguera Awaiting requested review from coseguera

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extension parsing mechanism should not fail if the extension returns null
3 participants
@MaggieKimani1 @andrueastman @baywet