Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates csproj release notes to point to Github release notes #927

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #923

@MaggieKimani1 MaggieKimani1 deleted the mk/add-release-notes-pointer branch July 6, 2022 09:58
@MaggieKimani1 MaggieKimani1 restored the mk/add-release-notes-pointer branch July 6, 2022 09:59
@MaggieKimani1 MaggieKimani1 reopened this Jul 6, 2022
@MaggieKimani1 MaggieKimani1 requested a review from baywet July 6, 2022 12:41
@baywet baywet enabled auto-merge July 6, 2022 12:43
@baywet baywet disabled auto-merge July 6, 2022 12:43
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the same change should probably be done for openapi.net and readers.

@baywet baywet enabled auto-merge July 6, 2022 12:44
@MaggieKimani1
Copy link
Contributor Author

actually, the same change should probably be done for openapi.net and readers.

Oh I missed that. Resolving..

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to remove the version in the link? This way we don't have to update it with every release, which I believe was part of @darrelmiller's point.

src/Microsoft.OpenApi/Microsoft.OpenApi.csproj Outdated Show resolved Hide resolved
@baywet baywet merged commit 521920d into vnext Jul 6, 2022
@baywet baywet deleted the mk/add-release-notes-pointer branch July 6, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Release Notes in csproj file to point to release notes on GitHub
2 participants