Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry install --no-dev #1378

Merged
merged 1 commit into from
Jun 1, 2022
Merged

poetry install --no-dev #1378

merged 1 commit into from
Jun 1, 2022

Conversation

dimbleby
Copy link
Member

@dimbleby dimbleby commented May 8, 2022

  • The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
  • Tests are included and/or updated for code changes.
  • Proper license headers are included in each file.

#1370 (comment)

@dimbleby dimbleby requested a review from a team as a code owner May 8, 2022 13:05
@qianz2
Copy link
Contributor

qianz2 commented May 9, 2022

Hi @dimbleby, do we have an issue related to this PR? What's the purpose of adding --no-dev to the poetry install command, could you explain it a bit? Thanks

@daniv-msft
Copy link
Contributor

Hi @dimbleby, do we have an issue related to this PR? What's the purpose of adding --no-dev to the poetry install command, could you explain it a bit? Thanks

@qianz2 Please find more details here: #1370
Also, adding @cormacpayne as he looked into the original issue.

@dimbleby
Copy link
Member Author

dimbleby commented May 9, 2022

specifically - as above - #1370 (comment)

I wouldn't expect that folk would want to install their dev dependencies in their deployment environment.

@daniv-msft
Copy link
Contributor

@cormacpayne As you had context on the original issue, do you see an issue with adding this --no-dev parameter?

@cormacpayne
Copy link
Contributor

This change looks good to me :shipit:

@daniv-msft daniv-msft merged commit 9dbab97 into microsoft:main Jun 1, 2022
@dimbleby dimbleby deleted the poetry-install-no-dev branch June 1, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants