Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Williamhe/1853186 update automation to use staging account #2072

Merged
merged 9 commits into from
Jul 20, 2023
Merged

Williamhe/1853186 update automation to use staging account #2072

merged 9 commits into from
Jul 20, 2023

Conversation

william-msft
Copy link
Contributor

@william-msft william-msft commented Jul 19, 2023 •
edited
Loading

  • The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as: https://devdiv.visualstudio.com/DevDiv/_boards/board/t/Oryx/Stories/?workitem=1853186
    Automation is switching from using Dev storage account to Stagging storage account, which requires a SAS token.
  • Tests are included and/or updated for code changes.
    • Successful test invocation of the Automation project for dotnet and python.
  • Proper license headers are included in each file.

@william-msft william-msft requested a review from a team as a code owner July 19, 2023 20:41
snehapar9
snehapar9 previously approved these changes Jul 19, 2023
View reviewed changes
cormacpayne
cormacpayne approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor refactoring comment, otherwise LGTM :shipit:

build/tools/Automation/DotNet/DotNetAutomator.cs Show resolved Hide resolved
@william-msft william-msft merged commit 8190134 into main Jul 20, 2023
2 of 3 checks passed
@william-msft william-msft mentioned this pull request Aug 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliMSFT waliMSFT waliMSFT left review comments

@snehapar9 snehapar9 snehapar9 left review comments

@cormacpayne cormacpayne cormacpayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@william-msft @cormacpayne @waliMSFT @snehapar9