Wali/dotnet test release with public binaires to private mcr #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniv-msft
reviewed
Oct 5, 2023
daniv-msft
previously approved these changes
Oct 6, 2023
daniv-msft
previously approved these changes
Oct 6, 2023
waliMSFT
commented
Oct 6, 2023
| # Added the [ "$ImageDebianFlavor" != "bullseye" ] condition to avoid creating bullseye images from `staging/oryx` repo. | ||
| # This is a temporary change only to release the dotnet 6,7,8 privately. | ||
| if [ shouldStageRuntimeVersion "dotnetcore" $VERSION_DIRECTORY ] && [ "$ImageDebianFlavor" != "bullseye" ] ; then | ||
| if shouldStageRuntimeVersion "dotnetcore" $VERSION_DIRECTORY ; then |
There was a problem hiding this comment.
please ignore this change. In previous commit I tried to fix one issue. In this commit I just reverted it back..
daniv-msft
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This PR is created for the below testing purpose.
We need to test if we can release the
baseImages and runTimeImagesto the staging repo (staging/oryx/base) of MCR. For the testing purpose I took the public binaries so that if anything went wrong in the release won't create any mess.