Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package references and model paths for the [Phi-3CookBook/tree/main/md/07.Labs/Csharp] samples #249

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

elbruno
Copy link
Contributor

@elbruno elbruno commented Jan 27, 2025

Purpose

Update package references and model paths for the [Phi-3CookBook/tree/main/md/07.Labs/Csharp] samples.
Updated Microsoft ML Onnx Runtime and related libraries to newer versions, ensuring compatibility. Modified model paths for Phi-3 and Phi-3.5 in comments and code. Corrected image loading syntax and updated model initialization to use a new Config class. Overall, these changes enhance clarity and maintainability.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by (https://azure.microsoft.com/products/phi-3)
which includes deployment, settings and usage instructions.

[ ] Yes
[X] No

Type of change

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[X] Other... Please describe: upgrade packages

Updated Microsoft ML Onnx Runtime and related libraries to newer versions, ensuring compatibility. Modified model paths for Phi-3 and Phi-3.5 in comments and code. Corrected image loading syntax and updated model initialization to use a new Config class. Overall, these changes enhance clarity and maintainability.
@leestott
Copy link
Contributor

@kinfey updates made to samples..
@elbruno thanks for the fix

@leestott leestott merged commit 65cf4b5 into microsoft:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants