PaYamlV3 OM schema & PFxExpressionYamlConverter changes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `PFxFunctionParameter` now supports `Default` keyword being a PFx expression. - `ComponentDefinition.DefinitionType` added with enum `ComponentDefinitionType`, to differentiate between Canvas and Command components. - Added tests for `PFxExpressionYamlConverter` to show the handling of trailing whitespace. Turns out YamlDotNet cannot support us forcing these to use Literal block syntax. - Adapted to add quotes around values which end with the tab character. - Use ImmutableArray instead of IReadOnlyList for options. - Updated `pa.schema.yaml` and added more tests.
swapnilbhalgat
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PFxFunctionParameternow supportsDefaultkeyword being a PFx expression.ComponentDefinition.DefinitionTypeadded with enumComponentDefinitionType, to differentiate between Canvas and Command components.PFxExpressionYamlConverterto show the handling of trailing whitespace. Turns out YamlDotNet cannot support us forcing these to use Literal block syntax.pa.schema.yamland added more tests.