Skip to content

Commit

Permalink
Updated rhtml template and fixed error output (#488)
Browse files Browse the repository at this point in the history
* Fixed errors output

* fixed rhtml template

* updated changelog

* Updated links in ReadMe

* Added license file
  • Loading branch information
AleksSavelev authored Oct 18, 2023
1 parent 60e8686 commit 437f6f7
Show file tree
Hide file tree
Showing 7 changed files with 40 additions and 9 deletions.
4 changes: 4 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This page contains information about changes to the PowerBI Visual Tools (pbiviz).

## 5.2.1
* Fixed errors output when packaging the visual
* Fixed `RHTML` template render error

## 5.2.0
* Integrated PAC validation

Expand Down
21 changes: 21 additions & 0 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) Microsoft Corporation.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,14 @@ pbiviz
```

## How to build a visual?
Refer to our [documentation repository](https://github.com/Microsoft/PowerBI-visuals)
Refer to our [documentation repository](https://learn.microsoft.com/en-us/power-bi/developer/visuals/develop-circle-card)

## Usage

You can learn more about using these tools in the following guides

* [Installation Guide](https://docs.microsoft.com/en-us/power-bi/developer/visuals/custom-visual-develop-tutorial#setting-up-the-developer-environment)
* [Usage Guide](https://docs.microsoft.com/en-us/power-bi/developer/visuals/custom-visual-develop-tutorial#creating-a-custom-visual)
* [Debugging Guide](https://microsoft.github.io/PowerBI-visuals/docs/how-to-guide/how-to-debug)
* [Usage Guide](https://learn.microsoft.com/en-us/power-bi/developer/visuals/develop-circle-card#create-a-development-project)
* [Debugging Guide](https://learn.microsoft.com/en-us/power-bi/developer/visuals/visuals-how-to-debug)

## PowerBI Visuals Tools Changes

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powerbi-visuals-tools",
"version": "5.2.0",
"version": "5.2.1",
"description": "Command line tool for creating and publishing visuals for Power BI",
"main": "./bin/pbiviz.js",
"type": "module",
Expand Down
4 changes: 3 additions & 1 deletion src/VisualManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ export default class VisualManager {

public generatePackage(verbose: boolean = false) {
const callback = (err: Error, stats: Stats) => {
this.parseCompilationResults(err, stats);
this.createPackageInstance();
const logs = this.validatePackage();
this.outputResults(logs, verbose);
this.parseCompilationResults(err, stats)
}
this.compiler.run(callback);
}
Expand Down Expand Up @@ -278,6 +278,8 @@ export default class VisualManager {
}
if (!err && !stats?.compilation.errors.length) {
ConsoleWriter.done('Build completed successfully');
} else {
process.exit(1);
}
}

Expand Down
7 changes: 6 additions & 1 deletion templates/visuals/rhtml/capabilities.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,10 @@
}
},
"suppressDefaultTitle": true,
"privileges": []
"privileges": [
{
"name": "WebAccess",
"parameters": ["*"]
}
]
}

0 comments on commit 437f6f7

Please sign in to comment.