Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding to utf-8 before writing to file. #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Encoding to utf-8 before writing to file. #706

wants to merge 1 commit into from

Conversation

chsamala
Copy link
Contributor

@chsamala chsamala commented Jun 4, 2020

Encoding to utf-8 before writing to file.

@chsamala
Encoding to utf-8 before writing to file.
f631030 
Encoding to utf-8 before writing to file.
jineshcodes
jineshcodes approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jineshcodes jineshcodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we still need it? If so lets make the same change for python 3 as well.

@jineshcodes jineshcodes self-requested a review November 23, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jineshcodes jineshcodes Awaiting requested review from jineshcodes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chsamala @jineshcodes