This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Added support for python 3 for DIY DSC #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 26, 2021 18:45
…e DROP OMI DEPENDENCY
jineshcodes
commented
Apr 19, 2021
added 7 commits
April 23, 2021 00:19
…e ones not required
jineshcodes
commented
May 5, 2021
added 2 commits
May 5, 2021 06:33
jineshcodes
commented
May 5, 2021
Bhargava-Chary-Chollaty
approved these changes
May 6, 2021
jineshcodes
pushed a commit
to microsoft/Build-PowerShell-DSC-for-Linux
that referenced
this pull request
May 10, 2021
Added support for python 3 for DIY DSC Updating the version of DSC to 1.2.0.0 for the changes introducted as a part of the PR: microsoft/PowerShell-DSC-for-Linux#789 These changes have to go in after the above PR is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes included as a part of the PR:
Description of the changes:
As a part of porting the code we had decided to keep the code for python3 in a seperate forlder.(Most of these changes were done as a part of OMSConfig Py3 support PR). The updated folder for python scripts is as follows:
The python version of the machine will be determined by checking the existance of python2 and python3 command. In this version python2 takes precidence if both python 2 and 3 are present. (This is done to maintain compabality for older distros.)
Instead of just logging success and failure a lot of debug and detailed logs ave been added. Going forward DSC will have two log files:
A lot of issues were discovered for the master branch, as the last release was done years back. I have tried to fix most of them. The issue were as a part of the DROP OMI DEPENDECY pr, which was only intended for omsconfig and ended up breaking DIY DSC.
Testing:
Manually tested for sanity and happy path secnarios on both python 2 and 3.
Distro testing is in progress using the test suite.
Bug bas planned for this week.