Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuditSetting Rule for Windows STIGs has an incorrect operator when evaluating Service Pack information #477

Merged
merged 1 commit into from
Aug 14, 2019
Merged

AuditSetting Rule for Windows STIGs has an incorrect operator when evaluating Service Pack information #477

merged 1 commit into from
Aug 14, 2019

Conversation

bcwilhite
Copy link
Contributor

@bcwilhite bcwilhite commented Aug 14, 2019 •
edited by athaynes
Loading

Pull Request (PR) description:

AuditSetting Rule for Windows STIGs has an incorrect operator when evaluating Service Pack information

This Pull Request (PR) fixes the following issues:

This fixes #476

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

jcwalker
jcwalker approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@jcwalker jcwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

japatton
japatton approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@japatton japatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcwilhite bcwilhite merged commit 841eb0b into 4.0.0 Aug 14, 2019
@bcwilhite bcwilhite deleted the bcwilhite#476 branch August 14, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcwalker jcwalker jcwalker approved these changes

@japatton japatton japatton approved these changes

@pgc1a pgc1a Awaiting requested review from pgc1a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcwilhite @jcwalker @japatton