stevehose#443 and #528 check list bug fixes #529

stevehose · 2019-11-13T22:29:10Z

Pull Request (PR) description: This PR fixes bug #443 and #528

This Pull Request (PR) fixes the following issues:

This fixes

New-StigCheckList not working - missing cmdlet Get-StigXccdfBenchmarkContent #443 New-StigCheckList not working - missing cmdlet Get-StigXccdfBenchmarkContent
New-StigChecklist should not require a ManualCheckFile #528 New-StigChecklist should not require a ManualCheckFile

Task list:

Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
Added/updated documentation, comment-based help and descriptions where appropriate?
Examples appropriately updated?
New/changed code adheres to Style Guidelines?
Unit and (optional) Integration tests created/updated where possible?

This change is

Module/STIG/Functions.Checklist.ps1

jcwalker

Just a couple of things.

Also, can we merge this into the 4.2.0 branch?

codecov-io · 2019-11-19T02:06:07Z

Codecov Report

Merging #529 into 4.2.0 will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           4.2.0    #529   +/-   ##
=====================================
  Coverage   78.1%   78.1%           
=====================================
  Files         16      16           
  Lines        201     201           
  Branches       3       3           
=====================================
  Hits         157     157           
  Misses        41      41           
  Partials       3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8afc6...bdb7914. Read the comment docs.

stevehose

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @bcwilhite and @jcwalker)

Module/STIG/Functions.Checklist.ps1, line 50 at r1 (raw file):

Previously, stevehose (Steve Hose) wrote…

Fixed.

Done.

Module/STIG/Functions.Checklist.ps1, line 66 at r1 (raw file):

Previously, stevehose (Steve Hose) wrote…

It's not. That wasn't code that I wrote and I understand why they did it. There is a better way and I've updated it.

Done.

bcwilhite

Steve, make sure you update the changelog.md with fix info.

stevehose

Done.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @jcwalker)

bcwilhite

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jcwalker)

* Updated based on issue (#523) * Feature request: additional support for servicerule properties #514 (#525) * Added property based on community request * updated issue version * Updated win10 system drive path in convert module (#526) * added support for 2012R2 MS/DC 2.17/2.18 (#532) * added support for 2012R2 MS/DC 2.17/2.18 * added new line on the xccdf * removed tab from processed xml. * updated to successfully parse Win10 V1R19 (#534) * added support for FireFox 4.27 (#541) * added support for IE 1.18 (#539) * added support for .net 4.0 V1R9 (#536) * Update PowerSTIG to parse the IIS 8.5 1.9 Site and Server STIGs (#537) * Initial Convert and update IIS 8.5 1.9 * remove n-2 STIGs * removed quotes * added newline to raw xccdf * updated based on PR feedback * Update PowerSTIG to successfully parse Microsoft SQL Server 2016 Instance STIG - Ver 1, Rel 7 (#544) * fixed and updated SQL Instance STIGs * updated sqlserver composite and removed tabs * updated sqlserver composite. * removed tabs * Updated JRE rule V-66941.a to be a org setting (#543) * updated JRE rule V-66941.a to be a org settings * updated name of processed STIG * update changelog * added space to TS build issue. * Need a test to verify the conversionstatus="fail" does not exist in processed STIGs (#550) * updated Win2016DC failed converts and added tests * removed V-73517 from MS-1.9 as the rule no longer exist. * Update PowerSTIG to parse and apply OfficeSystem 2013 STIG V1R9 / 2016 V1R1 (#553) * added Office-System2013 STIG support. * reconverted xccdfs, corrected issues in some processed stigs. * added OfficeSystem 2016 V1R1 STIG * updated changelog.md * stevehose#443 and #528 check list bug fixes (#529) * Update to fix checklist bugs * Fixed bug in checklist parameter ManualCheckFile * Updated Checklist Pester tests * Updates based upon PR comments * Updated changelog.md * Add test to assert dependent module versions (#555) * Added helper function And test to verify module versions * Added tests to assert dependant module versions. * Removed commented code * Removed whitespace * Update PowerSTIG to parse and apply Windows Server 2019 V1R2 STIG (#557) * added support for 2019 MS modified hardcoded parser rule ids to support 2019 MS * added support for 2019 DC STIG; parser update to address failed AD permission rules (ActiveDirectoryAuditRule) which isn't currently implemented * Added ProcessMitigation to WindowsServer composite * regenerated all xccdfs, 6 were corrected/modified * updated changelog.md * appveyor build issue - space insert * prep for 4.2.0 release, update changelog, filehash markdowns and module manifest Co-authored-by: Eric Jenkins <erjenkin@microsoft.com> Co-authored-by: Steve Hose <33662177+stevehose@users.noreply.github.com> Co-authored-by: Jason Walker <walkerjason@live.com>

* Updated based on issue (#523) * Feature request: additional support for servicerule properties #514 (#525) * Added property based on community request * updated issue version * Updated win10 system drive path in convert module (#526) * Updates for Issues #259 and #527 * added support for 2012R2 MS/DC 2.17/2.18 (#532) * added support for 2012R2 MS/DC 2.17/2.18 * added new line on the xccdf * removed tab from processed xml. * updated to successfully parse Win10 V1R19 (#534) * added support for FireFox 4.27 (#541) * added support for IE 1.18 (#539) * added support for .net 4.0 V1R9 (#536) * Update PowerSTIG to parse the IIS 8.5 1.9 Site and Server STIGs (#537) * Initial Convert and update IIS 8.5 1.9 * remove n-2 STIGs * removed quotes * added newline to raw xccdf * updated based on PR feedback * Version update * MInor updates * Update PowerSTIG to successfully parse Microsoft SQL Server 2016 Instance STIG - Ver 1, Rel 7 (#544) * fixed and updated SQL Instance STIGs * updated sqlserver composite and removed tabs * updated sqlserver composite. * removed tabs * Code changes to correct issues * Updated JRE rule V-66941.a to be a org setting (#543) * updated JRE rule V-66941.a to be a org settings * updated name of processed STIG * update changelog * added space to TS build issue. * Updates to add functionality and address bugs * Need a test to verify the conversionstatus="fail" does not exist in processed STIGs (#550) * updated Win2016DC failed converts and added tests * removed V-73517 from MS-1.9 as the rule no longer exist. * Update PowerSTIG to parse and apply OfficeSystem 2013 STIG V1R9 / 2016 V1R1 (#553) * added Office-System2013 STIG support. * reconverted xccdfs, corrected issues in some processed stigs. * added OfficeSystem 2016 V1R1 STIG * updated changelog.md * Update: duplicate rules for checklist & bug fixes * Updates to fix DSC results bugs * Fixed error in New-StigChecklist * Minor update to support debugging * Final commit prior to PR. Updated changelog. * stevehose#443 and #528 check list bug fixes (#529) * Update to fix checklist bugs * Fixed bug in checklist parameter ManualCheckFile * Updated Checklist Pester tests * Updates based upon PR comments * Updated changelog.md * Add test to assert dependent module versions (#555) * Added helper function And test to verify module versions * Added tests to assert dependant module versions. * Removed commented code * Removed whitespace * Update PowerSTIG to parse and apply Windows Server 2019 V1R2 STIG (#557) * added support for 2019 MS modified hardcoded parser rule ids to support 2019 MS * added support for 2019 DC STIG; parser update to address failed AD permission rules (ActiveDirectoryAuditRule) which isn't currently implemented * Added ProcessMitigation to WindowsServer composite * regenerated all xccdfs, 6 were corrected/modified * updated changelog.md * appveyor build issue - space insert * Updates to fix build bugs * Updated to fix bugs in build * Fix to missing reference * Build error fix - missing newline * prep for 4.2.0 release, update changelog, filehash markdowns and module manifest * Fix for build missing functions reference * Relocated file to be picked up during runtime * Minor update to remove test code * Updated for build errors * Updated processed SQL Server 1.3 files * Updates for PR * Updates for PR * Updated for PR * Updates for PR * Moving changes for SQL to another branch * Update for PR Co-authored-by: Eric Jenkins <erjenkin@microsoft.com> Co-authored-by: Brian Wilhite <bcwilhite@live.com> Co-authored-by: Jason Walker <walkerjason@live.com>

Steve Hose added 3 commits November 8, 2019 13:12

Update to fix checklist bugs

cc0c526

Fixed bug in checklist parameter ManualCheckFile

80b933c

Updated Checklist Pester tests

fb36383

stevehose requested a review from jcwalker November 14, 2019 14:24

jcwalker reviewed Nov 15, 2019

View reviewed changes

Module/STIG/Functions.Checklist.ps1 Outdated Show resolved Hide resolved

jcwalker reviewed Nov 15, 2019

View reviewed changes

Module/STIG/Functions.Checklist.ps1 Outdated Show resolved Hide resolved

jcwalker reviewed Nov 15, 2019

View reviewed changes

Updates based upon PR comments

db7b50b

stevehose changed the base branch from dev to 4.2.0 November 19, 2019 01:31

stevehose requested review from jcwalker and bcwilhite November 20, 2019 14:44

stevehose commented Nov 22, 2019

View reviewed changes

stevehose added this to the 4.2.0 milestone Nov 22, 2019

stevehose added bug Something isn't working In Progress labels Nov 22, 2019

jcwalker approved these changes Nov 25, 2019

View reviewed changes

bcwilhite approved these changes Dec 11, 2019

View reviewed changes

bcwilhite requested changes Dec 11, 2019

View reviewed changes

Updated changelog.md

216bfe7

stevehose commented Dec 11, 2019

View reviewed changes

Resolved merge conflict by adding new lines.

bdb7914

bcwilhite approved these changes Dec 16, 2019

View reviewed changes

bcwilhite approved these changes Dec 18, 2019

View reviewed changes

bcwilhite merged commit 84932d3 into 4.2.0 Dec 18, 2019

bcwilhite deleted the stevehose#443CheckList branch December 18, 2019 19:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stevehose#443 and #528 check list bug fixes #529

stevehose#443 and #528 check list bug fixes #529

stevehose commented Nov 13, 2019 •

edited by athaynes

Loading

jcwalker left a comment •

edited

Loading

codecov-io commented Nov 19, 2019 •

edited

Loading

stevehose left a comment

bcwilhite left a comment

stevehose left a comment

bcwilhite left a comment

stevehose#443 and #528 check list bug fixes #529

stevehose#443 and #528 check list bug fixes #529

Conversation

stevehose commented Nov 13, 2019 • edited by athaynes Loading

jcwalker left a comment • edited Loading

Choose a reason for hiding this comment

codecov-io commented Nov 19, 2019 • edited Loading

Codecov Report

stevehose left a comment

Choose a reason for hiding this comment

bcwilhite left a comment

Choose a reason for hiding this comment

stevehose left a comment

Choose a reason for hiding this comment

bcwilhite left a comment

Choose a reason for hiding this comment

stevehose commented Nov 13, 2019 •

edited by athaynes

Loading

jcwalker left a comment •

edited

Loading

codecov-io commented Nov 19, 2019 •

edited

Loading