Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG #855

Merged
merged 6 commits into from
Feb 28, 2021
Merged

Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG #855

merged 6 commits into from
Feb 28, 2021

Conversation

hinderjd
Copy link
Collaborator

@hinderjd hinderjd commented Feb 22, 2021 •
edited by athaynes
Loading

Pull Request (PR) description:
Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG
This Pull Request (PR) fixes the following issues:
Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG
This fixes #
#851
Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@hinderjd hinderjd added the enhancement New feature or request label Feb 22, 2021
@hinderjd hinderjd added this to the 4.8.0 milestone Feb 22, 2021
@hinderjd hinderjd self-assigned this Feb 22, 2021
@hinderjd hinderjd linked an issue Feb 22, 2021 that may be closed by this pull request
Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG #851
Closed
@hinderjd hinderjd changed the base branch from dev to 4.8.0 February 24, 2021 20:05
erjenkin
erjenkin suggested changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@erjenkin erjenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just need a few updates.

source/Module/Rule.VsphereAdvancedSettings/Convert/Methods.ps1 Outdated Show resolved Hide resolved
source/Module/Rule.VsphereAdvancedSettings/Convert/Methods.ps1 Outdated Show resolved Hide resolved
source/Module/Rule.VsphereAdvancedSettings/Convert/VsphereAdvancedSettingsRule.Convert.psm1 Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #855 (23b1e35) into 4.8.0 (a830e70) will not change coverage.
The diff coverage is 33%.

Impacted file tree graph

@@         Coverage Diff          @@
##           4.8.0   #855   +/-   ##
====================================
  Coverage     82%    82%           
====================================
  Files        147    147           
  Lines       4956   4956           
====================================
  Hits        4082   4082           
  Misses       874    874

bcwilhite
bcwilhite approved these changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@bcwilhite bcwilhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hinderjd hinderjd merged commit 16ee2b5 into 4.8.0 Feb 28, 2021
@hinderjd hinderjd deleted the hinderjd#852 branch March 14, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjenkin erjenkin erjenkin approved these changes

@bcwilhite bcwilhite bcwilhite approved these changes

Assignees

@hinderjd hinderjd

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Update PowerSTIG to successfully parse/apply VMware 6.5 ESXI V2R1 STIG
4 participants
@hinderjd @codecov-io @bcwilhite @erjenkin