Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PowerSTIG to successfully parse/apply Microsoft Office System 2016 STIG - Ver 2, Rel 1 #946 #947

Merged
merged 9 commits into from
Aug 19, 2021

Conversation

hinderjd
Copy link
Collaborator

@hinderjd hinderjd commented Jul 29, 2021

Pull Request (PR) description:

Update PowerSTIG to successfully parse/apply Microsoft Office System 2016 STIG - Ver 2, Rel 1

This Pull Request (PR) fixes the following issues:

Update PowerSTIG to successfully parse/apply Microsoft Office System 2016 STIG - Ver 2, Rel 1

This fixes #946

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@hinderjd hinderjd added the enhancement New feature or request label Jul 29, 2021
@hinderjd hinderjd added this to the 4.10.0 milestone Jul 29, 2021
@hinderjd hinderjd self-assigned this Jul 29, 2021
HKCU\Software\Policies\Microsoft\Office\16.0\common\security

Criteria: If the value OpenXMLEncryption is REG_SZ = "Microsoft Enhanced RSA and AES Cryptographic Provider,AES 256,256", this is not a finding.</RawString>
<ValueData>Microsoft Enhanced RSA and AES Cryptographic Provider AES 256 256</ValueData>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hardcoded rule and appears to be incorrect, in previous STIGs too. I believe the way it needs to be written is all values in the valuedata section of the hardcoded rule needs to be in quotes.

HKCU\Software\Policies\Microsoft\Office\16.0\common\security

Criteria: If the value DefaultEncryption12 is REG_SZ = "Microsoft Enhanced RSA and AES Cryptographic Provider,AES 256,256", this is not a finding.</RawString>
<ValueData>Microsoft Enhanced RSA and AES Cryptographic Provider AES 256 256</ValueData>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hardcoded rule and appears to be incorrect, in previous STIGs too. I believe the way it needs to be written is all values in the valuedata section of the hardcoded rule needs to be in quotes.

@bcwilhite bcwilhite linked an issue Aug 17, 2021 that may be closed by this pull request
@bcwilhite bcwilhite changed the title Parse\Apply Microsoft Office System 2016 STIG - Ver 2, Rel 1 #946 Update PowerSTIG to successfully parse/apply Microsoft Office System 2016 STIG - Ver 2, Rel 1 #946 Aug 17, 2021
@bcwilhite bcwilhite merged commit 6b0d18d into 4.10.0 Aug 19, 2021
@bcwilhite bcwilhite deleted the hinderjd#946 branch August 19, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse\Apply Microsoft Office System 2016 STIG - Ver 2, Rel 1
3 participants