Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Windows Server 2019 V2R1 V-205763 generating an exception #968

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fixed: Windows Server 2019 V2R1 V-205763 generating an exception #968

merged 1 commit into from
Aug 30, 2021

Conversation

bcwilhite
Copy link
Contributor

@bcwilhite bcwilhite commented Aug 24, 2021 •
edited by athaynes
Loading

Pull Request (PR) description:

Fixed: Windows Server 2019 V2R1 V-205763 generating an exception. The UserRights composite resource was creating an arraylist to add identities through a loop and then assigning those identities to the UserRights resource once the loop finished. This is an issue if null is used, since creating an array and only adding null to it will cause the "Identity" parameter to have a "value" instead of an empty string or null setting. This was corrected by detecting NULL as a string and assigning Identity as $null rather than @($null).

This Pull Request (PR) fixes the following issues:

This fixes #827

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@erjenkin erjenkin linked an issue Aug 24, 2021 that may be closed by this pull request
Windows Server 2019 V2R1 V-205763 generating an exception #827
Closed
@bcwilhite bcwilhite merged commit 6083e13 into 4.10.1 Aug 30, 2021
@bcwilhite bcwilhite deleted the bcwilhite#827 branch August 30, 2021 12:33
bcwilhite added a commit that referenced this pull request Aug 31, 2021
@erjenkin @bcwilhite
4.10.1 to 4.11.0 (#971)
62c37b5 
* updated code to better handle NULL Id (#968)

* Fixed: PowerSTIG should honor Boolean with all composite resources (#970)

* fixed bool composite issue

* fixed typo

* adjusted test case for string instead of bool

Co-authored-by: Brian Wilhite <bcwilhite@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjenkin erjenkin erjenkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Server 2019 V2R1 V-205763 generating an exception
2 participants
@bcwilhite @erjenkin