[Settings][New+]Fixed crash when canceling template folder selection (#…

…35060) [New+] Fixed crash when cancel template folder selection
microsoft · Sep 25, 2024 · cf5adda · cf5adda
1 parent 7c48f5e
commit cf5adda
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/settings-ui/Settings.UI/ViewModels/NewPlusViewModel.cs b/src/settings-ui/Settings.UI/ViewModels/NewPlusViewModel.cs
@@ -261,7 +261,7 @@ private void OpenNewTemplateFolder()
         private async void PickNewTemplateFolder()
         {
             var newPath = await PickFolderDialog();
-            if (newPath.Length > 1)
+            if (!string.IsNullOrEmpty(newPath))
             {
                 TemplateLocation = newPath;
             }
@@ -270,8 +270,7 @@ private async void PickNewTemplateFolder()
         private async Task<string> PickFolderDialog()
         {
             var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(App.GetSettingsWindow());
-            string pathFolder = await Task.FromResult<string>(ShellGetFolder.GetFolderDialogWithFlags(hwnd, ShellGetFolder.FolderDialogFlags._BIF_NEWDIALOGSTYLE));
-            return pathFolder;
+            return await Task.FromResult(GetFolderDialogWithFlags(hwnd, FolderDialogFlags._BIF_NEWDIALOGSTYLE));
         }
 
         private void SaveSettingsToJson()