Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Implement layout quick swap #10026

Closed
5 of 6 tasks
enricogior opened this issue Mar 4, 2021 · 4 comments
Closed
5 of 6 tasks

[FancyZones] Implement layout quick swap #10026

enricogior opened this issue Mar 4, 2021 · 4 comments
Assignees
@ivan100sic
Labels
Issue-Feature A planned feature addition to a product Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@enricogior
Copy link
Contributor

enricogior commented Mar 4, 2021 •
edited
Loading

This is subtask #2 for #1411

After #10025 is implemented, add the layout swap shortcut handler in FZ.

  • handler to swap the current layout with the layout bound to the selected shortcut
  • show a visual feedback if the selected shortcut is not bound to any layout (optional, we don't have a spec for this yet)
  • flash the new layout for 1 second (we will validate this value once the feature is implemented)
  • add telemetry event
  • fire telemetry event
  • update FZ Editor with the shortcut modifiers
@enricogior enricogior added Product-FancyZones Refers to the FancyZones PowerToy Issue-Feature A planned feature addition to a product labels Mar 4, 2021
@enricogior enricogior mentioned this issue Mar 4, 2021
Closed
@gczark
Copy link

gczark commented Mar 4, 2021

Could it be the same behaviour like before, switching layouts with drag window + shift to activate zone + num rather than ctr + alt + num?

@enricogior
Copy link
Contributor Author

@gczark
at the moment we are not planning to support switching layout while shift dragging because it can cause all sort of bugs.

@crutkas crutkas added the Status-In progress This issue or work-item is under development label Mar 17, 2021
@ivan100sic ivan100sic mentioned this issue Mar 18, 2021
Merged
10 tasks
@SeraphimaZykova SeraphimaZykova mentioned this issue Mar 22, 2021
Merged
10 tasks
@ivan100sic ivan100sic added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 23, 2021
@enricogior enricogior added Status-In progress This issue or work-item is under development and removed Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Mar 23, 2021
@enricogior
Copy link
Contributor Author

We still need to fire the telemetry event, before labelling as fix-committed.

@ivan100sic ivan100sic mentioned this issue Mar 24, 2021
Merged
10 tasks
@enricogior enricogior added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 24, 2021
@crutkas
Copy link
Member

crutkas commented Apr 1, 2021

This has been resolved in the 0.35 release. https://github.com/microsoft/PowerToys/releases/latest

@crutkas crutkas closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan100sic ivan100sic

Labels
Issue-Feature A planned feature addition to a product Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crutkas @enricogior @ivan100sic @gczark